split click.h into multiple, independent modules #15
No reviewers
Labels
No labels
IncrementalParsing
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
OtherCompilersCompliance
Kind
StandardCompliance
Performance
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Scope/Lexer
Scope/Parser
Scope/PreProcessor
Scope/PublicApi
Scope/Sema
Status
Abandoned
Status
Blocked
Status
Need More Info
Testing
UserExperience
No milestone
No project
No assignees
2 participants
Notifications
Total time spent: 18 minutes 10 seconds
Due date
thacuber2a03
18 minutes 10 seconds
No due date set.
Dependencies
No dependencies set.
Reference
click-project/click!15
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refactor/split-click-header"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
or, at least, tries to. some things might still be broken after this, and some things might not be on their correct places.
this closes #14, or at least it should
#include <click/util.h>within common.h bdbf64800dWIP: split click.h into multiple, independent modulesto split click.h into multiple, independent modulessplit click.h into multiple, independent modulesto WIP: split click.h into multiple, independent modules@alexander.nutz need your review here
@ -11,3 +5,4 @@extern "C" {#endif// TODO(thacuber2a03): should these flags stay here?move these, and click_unreachable and stuff, into compiler.h
"and stuff"? so, most of what is in common.h? or I missed something else?
well we could move panics too
@ -0,0 +1,68 @@#ifndef cpp_hpp_INCLUDEDrename file to obj.hpp or sth
@ -0,0 +1,68 @@#ifndef cpp_hpp_INCLUDED#define cpp_hpp_INCLUDEDinclude def for
click_newand other object stuff@ -0,0 +63,4 @@T* raw() const { return _ptr; }};} // namespace click#endif // __cplusplusremove this line
@ -0,0 +1,14 @@#ifndef lexer_h_INCLUDEDplease merge this header with the tokenty and stuff; we don't need that much splitting
I honestly forgot tokens.h was a thing that did in fact exist before making this file but sure
71c6e7738btoc8f250826fFUUCK oops
@ -0,0 +1,25 @@#ifndef bigint_h_INCLUDEDneeds to be prefixed with click_
@ -0,0 +1,16 @@#ifndef arena_h_INCLUDEDalso needs to be prefixed with click_
@ -0,0 +1,50 @@#ifndef common_h_INCLUDEDprefix with click_
funny, Kakoune does the header guard automatically based on the buffer name alone
@ -0,0 +1,223 @@#ifndef document_h_INCLUDEDprefix with _click
@ -0,0 +1,14 @@#ifndef lexer_h_INCLUDED#define lexer_h_INCLUDEDprefix eith _click
@ -0,0 +1,85 @@#ifndef obj_h_INCLUDEDguess what
prefix with click
uh wtf also prefix with click
yep
@ -0,0 +1,164 @@#ifndef util_h_INCLUDED...
give me a while
_click278190f7a2eh not a fan of the lexer include here
what do you suggest? just remove it?
@ -0,0 +1,16 @@#ifndef _click_common_h_INCLUDEDmove all assert related stuff from util.h into here
@ -0,0 +11,4 @@# define click_noreturn __attribute__((noreturn))# define click_unreachable_impl __builtin_unreachable()# define click_deprecated(message) \__attribute__((deprecated(message)))remove this include
@alexander.nutz check it now
WIP: split click.h into multiple, independent modulesto split click.h into multiple, independent modules5db4705286to7bb8ae08dd