feat: disallow single-line comments in < c99 #9

thacuber2a03 · 2025-10-20T19:12:57+02:00

thacuber2a03 commented

2025-10-20 19:12:57 +02:00

...unless the respective extension flag is set

this closes #1

...unless the respective extension flag is set this closes #1

thacuber2a03 added 1 commit

2025-10-20 19:12:58 +02:00

feat: disallow single-line comments in <= c99 d42315d3ce

...unless the respective extension flag is set

alexander.nutz requested changes

2025-10-20 19:16:26 +02:00

Dismissed

libclick/lexer.c Outdated

					
				@ -724,6 +724,10 @@ static lex_res lex_func_delim(lexer* lexer)

				static lex_res lex_func_click_doc_comment(lexer* lexer)

				{

				  click_lang_config* lang = &lexer->document->lang;

actually no; this function should only exist for the clike lang family; rename the function instead and remove it from the c family lex list

it never was in the c-family lex list so that's taken care of
although, to be real, the branch probably wouldn't have been taken if this function really is only called for clike
(by the way, the function says "click", all of them do; I thought you had changed the name)

it never was in the c-family lex list so that's taken care of although, to be real, the branch probably wouldn't have been taken if this function really is only called for clike (by the way, the function says "click", all of them do; I thought you had changed the name)

@thacuber2a03 wrote in https://gitea.vxcc.dev/click-project/click/pulls/9#issuecomment-38:

it never was in the c-family lex list so that's taken care of although, to be real, the branch probably wouldn't have been taken if this function really is only called for clike (by the way, the function says "click", all of them do; I thought you had changed the name)

ohh oops I s/clike/click...

can you rename the function in this PR too?

@thacuber2a03 wrote in https://gitea.vxcc.dev/click-project/click/pulls/9#issuecomment-38: > it never was in the c-family lex list so that's taken care of although, to be real, the branch probably wouldn't have been taken if this function really is only called for clike (by the way, the function says "click", all of them do; I thought you had changed the name) ohh oops I s/clike/click... can you rename the function in this PR too?